Prepare for 2023.3: Move some tasks to background thread. #5446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the commit below, FSRecords update operations are forbidden in EDT thread. JetBrains/intellij-community@78f7474 For this reason, we delegate a few method calls to Background Thread in order to make sure it will not crash. We do it via a synchrounous BGT call, so EDT still stops and waits until the aciton is completed, like it was before this change.
github-actions
bot
added
product: CLion
mai93
approved these changes
Oct 10, 2023
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the commit below, FSRecords update operations are forbidden in EDT thread. JetBrains/intellij-community@78f7474
For this reason, we delegate a few method calls to Background Thread in order to make sure it will not crash. We do it via a synchrounous BGT call, so EDT still stops and waits until the aciton is completed, like it was before this change.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change