Fix manual targets sync for target explicitly specified #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerhu
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
rogerhu
changed the title
…ts_sync: true flag The shard_sync: true flag must be set to expand the targets.
rogerhu
force-pushed
the
rogerh/ISSUE-4546-4
branch
from
f484ee0
to
6808626
Compare
blorente
approved these changes
Oct 18, 2023
github-actions
bot
removed
the
awaiting-review
Yep! I have to file a ticket apparently since the Bazel IntelliJ docs are not open source. =) https://bazelbuild.slack.com/archives/C025SBYFC4E/p1697741079375969 |
|
Created a ticket here: #5590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR is a continuation of #4546. One issue is that for manual targets specified, they are also excluded without this change (see #4546 (comment)).
This fix will only work currently if the shard_sync: true. Otherwise the query will not be performed. I pushed a second commit to make this change explicit. Otherwise, two flags must be set for this part to work.
Issue number: #4546
Description of this change
When
allow_manual_targets_sync: trueis set, this change will allow manual targets to be part of the target query. Because expansion of build targets currently only occur when the sharding approach is enabled, this change would also switch on theshard_sync: trueoption to enable this query to occur. The alternative would be to create another option to expand the query, so I wanted to get feedback about it.I've also modified unit tests to perform the check for both on/off, asserting the presence of the manual attr query.