Make //clwb(plugin) and //cpp(plugin) dependency on cidr.lang optional: plugin xmls split #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujohnny
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
3 tasks
github-actions
bot
added
product: CLion
blorente
approved these changes
Oct 17, 2023
| VirtualFile getSourceFileForHeaderFile(Project project, VirtualFile headerFile); | ||
|
|
||
| static VirtualFile findAndGetSourceFileForHeaderFile(Project project, VirtualFile headerFile) { | ||
| SourceFileFinder finder = EP_NAME.getPoint().extensions().findFirst().orElse(null); |
There was a problem hiding this comment.
Could we make it hard-error if there are more than one registered EPs here? Otherwise there's nothing telling us we shouldn't register more than one.
There was a problem hiding this comment.
Thanks for checking the review. I updated this part and similar part of the code in clwb.
Provide access via EP
Provide access via EP
ujohnny
force-pushed
the
enovozhilov/optional-cidr-lang
branch
from
0784fbf
to
5d74726
Compare
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #5472
Description of this change
Long story short:
com.intellij.modules.cidr.langis going to become optional in CLion at some point. All the usages of code exported fromcom.intellij.modules.cidr.langare moved to optional plugin xmls, so plugin won't emit lots of exceptions and break the IDE if the mentioned module is not available.A little bit more detailed here. We (CLion team) are working on deprecation of the old language engine. Parts of it which are not going to be deprecated are moved to
cidr-base-pluginlibrary, which is a part ofCIDR Base (com.intellij.cidr.base)essential CLion plugin, so any symbol fromcidr-base-pluginwill always be available. Though that does not apply toc-pluginlibrary which is a part ofcom.intellij.modules.cidr.langmodule.At this point the goal of this change is to make Bazel for CLion tolerant to disabled
com.intellij.modules.cidr.lang. We're going to contribute further to adjust existing code which is moved to*.oclang(.*)?packages in the review to preserve the features when only the new language engine is available.