fix: Mark package with BUILD.bazel file in completion #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebarrau
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
|
Tested on IJ UE 2023.2 and CLion 2023.2, and it works. |
blorente
approved these changes
Oct 24, 2023
mai93
approved these changes
Oct 24, 2023
blorente
pushed a commit
to blorente/intellij
that referenced
this pull request
Nov 1, 2023
In my current real version of the plugin (4023-171-api-version-232-api-version-232), a BUILD.bazel file already marks the directory as a bazel package. In the apple branch it does not. This attempts to fix this. Upstream-PR: bazelbuild#5526 Reviewed-by: Daniel Wagner-Hall <[email protected]> Reviewed-by: Borja Lorente <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Discussion thread for this change
Discussed offline with @blorente. This looks like a regression.
Description of this change
Mark package with BUILD.bazel file in completion
Diff of the behavior
The base branch for this PR, before change
In this repo under example/go/with_proto
Behavior: proto is a directory, it should be a package
After the change
In this repo under example/go/with_proto
Behavior: proto is a package, as expected