Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not complete ignored directories #5573

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: Do not complete ignored directories #5573

merged 2 commits into from
Nov 16, 2023

Conversation

stevebarrau
Copy link
Contributor

@stevebarrau stevebarrau commented Oct 31, 2023 •
edited
Loading

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Discussion thread for this change

Discussed offline with @blorente.

Description of this change

Do not complete ignored directories in a label in build files.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Oct 31, 2023
blorente
blorente approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@blorente blorente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we've tested internally and it makes results more accurate. Will merge in a couple of days.

@stevebarrau stevebarrau force-pushed the do-not-complete-ignored-directories branch from a53d909 to 4414542 Compare November 7, 2023 10:37
@blorente blorente merged commit fc41b3e into bazelbuild:master Nov 16, 2023
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Nov 16, 2023
@tpasternak tpasternak mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blorente blorente blorente approved these changes

@mai93 mai93 Awaiting requested review from mai93 mai93 is a code owner

@jastice jastice Awaiting requested review from jastice

@tpasternak tpasternak Awaiting requested review from tpasternak tpasternak is a code owner

@agluszak agluszak Awaiting requested review from agluszak agluszak is a code owner

Assignees

@tpasternak tpasternak

@blorente blorente

@mai93 mai93

Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Bazel IntelliJ Plugin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevebarrau @blorente @tpasternak @mai93