Prepare for 2024.1: convert kotlin's Sequence to java's Iterable #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExtensionPointImpl is now writen in Kotlin and extends Sequence instead of Iterable
tpasternak
force-pushed
the
2041-prep-1
branch
from
2568246
to
ef2c786
Compare
github-actions
bot
added
product: IntelliJ
jastice
approved these changes
Jan 19, 2024
| @@ -123,7 +126,7 @@ public void testAddJarsForSourceTarget_attchClassJarForKotlinTarget() { | |||
| .build(); | |||
| ArrayList<BlazeJarLibrary> genJars = new ArrayList<>(); | |||
|
|
|||
| for (BlazeJavaSyncAugmenter augmenter : augmenters) { | |||
| for (BlazeJavaSyncAugmenter augmenter : toIterable(augmenters)) { // #api233 - in 2024.1 ExtensionPointImpl implements Sequenec instead of Iterable | |||
github-actions
bot
removed
the
awaiting-review
ahmedyarub
pushed a commit
to ahmedyarub/intellij
that referenced
this pull request
Jan 19, 2024
…elbuild#5967) ExtensionPointImpl is now writen in Kotlin and extends Sequence instead of Iterable
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtensionPointImpl is now writen in Kotlin and extends Sequence instead of Iterable
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change