Fix imports for go modules named "external"

[muldrik]

Fixes #6324

Checklist

• I have filed an issue about this change and discussed potential changes with the maintainers.
• I have received the approval from the maintainers to make this change.
• This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #6324

Description of this change

If the package is literally named "external", the transformation was incorrect. Example:

String from real logs: /private/var/tmp/_bazel_muldrik/79e0cc1117c2f3c124d7043e835ad8a1/execroot/_main/external/gazelle~~go_deps~io_k8s_sigs_cluster_api/controllers/external/doc.go

Actual resulting transformation (breaks intellij imports):
/private/var/tmp/_bazel_muldrik/79e0cc1117c2f3c124d7043e835ad8a1/external/doc.go

Expected:
/private/var/tmp/_bazel_muldrik/79e0cc1117c2f3c124d7043e835ad8a1/external/gazelle~~go_deps~io_k8s_sigs_cluster_api/controllers/external/doc.go

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[sgowroji]

Hi @muldrik, Could you please sign the CLA?

[muldrik]

Could you please sign the CLA?

@sgowroji Hi, done.

[blorente]

Hey! Thanks a lot for your contribution! I wrote a small test case to check that it works (it does! 🎉 ), I'll open a PR to this PR, and this will be ready to merge once it merges!

[blorente]

Actually, I can't seem to be able to open PRs to your fork, so could you pull this commit into your PR please?

[muldrik]

@blorente Thanks, done!
By the way, how long will this approximately take to end up in the released version installable from the marketplace?

[blorente]

@muldrik Thanks!
To be completely honest, I don't know. We maintain a fork of the plugin internally, so we release at a very different cadence and track master upstream. @mai93 , @tpasternak, or @sgowroji might have more insight into it.

[mai93]

the next release is to be cut on the 9th of April and it will be available in the beta channel in marketplace in the 11th of April and then in the stable channel after 2 weeks from that.