Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace zip with default Bazel zipper #6328

Closed
wants to merge 1 commit into from

Conversation

blorente
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

zip might not be available in all machines. Specifically, it might not be available in Remote Build Execution environments. Instead, we use Bazel's built-in zipper.

`zip` might not be available in all machines.
Specifically, it might not be available in Remote Build Execution
environments.
@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Mar 28, 2024
@blorente blorente closed this Mar 28, 2024
@blorente blorente deleted the blorente/fix-zip-issues branch March 28, 2024 15:49
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Mar 28, 2024
@blorente
Copy link
Collaborator Author

This needs more investigation, seems like the bazel zipper doesn't create files just like the rest of the java wants them to.

@sgowroji sgowroji added product: IntelliJ IntelliJ plugin topic: bazel Bazel integration (external repositories, aspects, flags, etc) labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: IntelliJ IntelliJ plugin topic: bazel Bazel integration (external repositories, aspects, flags, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants