fix: Rely on the bazel zipper instead of zip #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blorente
requested review from
mai93,
jastice,
tpasternak and
agluszak
as code owners
github-actions
bot
added
the
awaiting-review
sgowroji
added
product: IntelliJ
agluszak
approved these changes
Jun 5, 2024
|
Yeah, it wasn't my happiest PR to write 😅 . There are java tools like jarjar which can do this, but I erred on the side of not introducing another dependency. |
github-actions
bot
removed
the
awaiting-review
|
ok, now we have #6468 |
|
I’ll get on this right now.
…On Thu, 6 Jun 2024 at 14:31, Tomasz Pasternak ***@***.***> wrote:
ok, now we have #6468 <#6468>
—
Reply to this email directly, view it on GitHub
<#6462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABMW6PWA57DUU4IKNT3FYI3ZGBQC7AVCNFSM6AAAAABIYTABVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJSGUYDQMJXGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
N/A
Description of this change
Not all environments have
zipin their path. For instance, some Remote Execution environments like to have very lean workers. Furthermore, we shouldn't rely on all environments having the same version. We replace zip with the bazel jar handler.We have been using this change internally to build the plugin against our build environment for a few months now.