Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6721] Don't set ExternalWorkspace.repoName() to null when same as… #6722

Merged

Conversation

mtoader
Copy link
Contributor

@mtoader mtoader commented Sep 4, 2024

… name()

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Discussion thread for this change

Issue number: #6721

Description of this change

This reverts a change that collapsed repoName to null when the same as name for an external repository. T'was unnecessary.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Sep 4, 2024
@mtoader mtoader force-pushed the mtoader/fix-external-repository-data branch from b2a0b83 to 1eb3ddd Compare September 4, 2024 08:21
@mtoader mtoader force-pushed the mtoader/fix-external-repository-data branch from 1eb3ddd to 522e149 Compare September 4, 2024 08:22
@tpasternak tpasternak merged commit 04de8bc into bazelbuild:master Sep 4, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 4, 2024
@mtoader mtoader deleted the mtoader/fix-external-repository-data branch September 4, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants