fix(qsync): NPE in "Add to project" panel action #6967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A comment contains a warning that there should be at least two packages found in order to provide user a choice. However in some cases there is only a single package to add. For this reason, we stop the lookup if it reaches project root, but we don't add a package automatically, so a user can always reject the change. closes bazelbuild#6966
github-actions
bot
added
product: CLion
xuansontrinh
previously approved these changes
Nov 6, 2024
ujohnny
reviewed
Nov 6, 2024
| do { | ||
| cancellationCheck.run(); | ||
| packages = runQuery(forPath); | ||
| if (!packages.isEmpty()) { | ||
| candidates.add(new CandidatePackage(forPath, packages.size())); | ||
| } | ||
| forPath = forPath.getParent(); | ||
| } while (candidates.size() < 2 && packages.size() < 2); | ||
| } while (candidates.size() < 2 && packages.size() < 2 && forPath != null); |
There was a problem hiding this comment.
forPath != null
this could become an infinite loop
Returns the parent path, or null if this path does not have a parent.
There was a problem hiding this comment.
what do you mean?
There was a problem hiding this comment.
it's a Path, running .getParent on it must end with a null eventually
There was a problem hiding this comment.
oh, my bad, I'm so sorry about that
ujohnny
approved these changes
Nov 6, 2024
| do { | ||
| cancellationCheck.run(); | ||
| packages = runQuery(forPath); | ||
| if (!packages.isEmpty()) { | ||
| candidates.add(new CandidatePackage(forPath, packages.size())); | ||
| } | ||
| forPath = forPath.getParent(); | ||
| } while (candidates.size() < 2 && packages.size() < 2); | ||
| } while (candidates.size() < 2 && packages.size() < 2 && forPath != null); |
There was a problem hiding this comment.
oh, my bad, I'm so sorry about that
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A comment contains a warning that there should be at least two packages found in order to provide user a choice. However in some cases there is only a single package to add.
For this reason, we stop the lookup if it reaches project root, but we don't add a package automatically, so a user can always reject the change.
closes #6966
qsync-add-to-project.mov
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change