Add support for Kotlin 2.2+ with versioned artifact system #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agluszak
requested review from
Bencodes,
ahumesky,
cgruber,
nkoroste and
restingbull
as code owners
agluszak
force-pushed
the
generate-artifacts
branch
from
3597a73 to
081ea48
Compare
Kotlin 2.2 removed trove4j and android-extensions jars from the distribution. This change introduces version-specific artifact definitions (artifacts_2.1.bzl and artifacts_2.2.bzl) to handle these differences, with automatic selection based on Kotlin version. Updates default Kotlin version to 2.2. Changes: - Created WriteKotlinArtifacts tool to generate artifact definitions - Added artifacts_2.1.bzl (includes trove4j) and artifacts_2.2.bzl - Updated compiler.bzl to use KOTLIN_STDLIBS from artifacts - Updated default Kotlin version to 2.2.21 - Added custom_compiler_version example to test backward compatibility - Updated jdeps plugin imports to use K2 FIR APIs Fixes bazelbuild#1373
agluszak
force-pushed
the
generate-artifacts
branch
from
081ea48 to
2763b94
Compare
|
I think something is slightly off with the stdlib: and possible the plugin: How about we break this up into versioning artifacts and updating to 2.2+? I can't quite figure out which is breaking the integration tests. |
|
So it looks like it's about a stdlib version mismatch. |
|
So I'm not sure if this versioning thingy is going to work because of bootstrapping :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin 2.2 removed trove4j and android-extensions jars from the distribution. This change introduces version-specific artifact definitions (artifacts_2.1.bzl and artifacts_2.2.bzl) to handle these differences, with automatic selection based on Kotlin version. Updates default Kotlin version to 2.2.
Changes:
Fixes #1373