Skip to content

Commit

Permalink
refactor(pypi): use a macro to define whl_library targets (#2347)
Browse files Browse the repository at this point in the history
Summary:
- refactor: Start implementing whl_library_targets
- refactor: start using whl_library_targets macro
- refactor: generate config settings in the new macro
- refactor: copy_files in the new macro
- refactor: move entry_point generation to the macro
- refactor: move the py_library and whl generation to the new macro

This makes the code more maintainable by reducing the amount of tests
that are comparing BUILD.bazel outputs.
  • Loading branch information
aignas authored Oct 28, 2024
1 parent f8d4135 commit 4623990
Show file tree
Hide file tree
Showing 8 changed files with 786 additions and 902 deletions.
4 changes: 2 additions & 2 deletions examples/bzlmod/MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions python/private/pypi/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ bzl_library(
name = "generate_whl_library_build_bazel_bzl",
srcs = ["generate_whl_library_build_bazel.bzl"],
deps = [
":labels_bzl",
"//python/private:normalize_name_bzl",
"//python/private:text_util_bzl",
],
)

Expand Down
Loading

0 comments on commit 4623990

Please sign in to comment.