Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixed_langauge_library #1293

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

brentleyjones
Copy link
Collaborator

@brentleyjones brentleyjones commented Jul 16, 2024

Replaces experimental_mixed_langauge_library in rules_apple. Meant to support SE-0403.

@brentleyjones brentleyjones force-pushed the bj/mixed_language_library branch 3 times, most recently from 413d967 to cf6e193 Compare July 18, 2024 19:40
swift/internal/module_maps.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
@brentleyjones
Copy link
Collaborator Author

Since we make sure that #import <ModuleName/ModuleName-Swift.h> works (though I need to make that work for the _clang target as well I guess...), I think a header map can be made as a target before a mixed_language_target and passed in the same way as it would for a normal {objc,swift}_library target. If that's the case, rules_swift wouldn't need to mess with them at all.

Copy link
Contributor

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for starting the move over to rules_swift, this is looking great!

swift/internal/feature_names.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
swift/mixed_language_library.bzl Outdated Show resolved Hide resolved
@brentleyjones brentleyjones force-pushed the bj/mixed_language_library branch 7 times, most recently from 16b82ca to 6e936fe Compare July 24, 2024 01:25
@brentleyjones brentleyjones force-pushed the bj/mixed_language_library branch 8 times, most recently from bc58c59 to 8394a79 Compare September 27, 2024 18:44
Replaces `experimental_mixed_langauge_library` in rules_apple. Meant to support SE-0403.

Signed-off-by: Brentley Jones <[email protected]>
@brentleyjones
Copy link
Collaborator Author

There is a request to allow the macro to use non-standard rules for the clang and swift targets. So instead of swift_library one could use their own custom_swift_library. I think this can be done in a followup change, to prevent blocking the core functionality here.

@brentleyjones brentleyjones merged commit be8bc73 into master Oct 1, 2024
14 checks passed
@brentleyjones brentleyjones deleted the bj/mixed_language_library branch October 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants