-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memoize computation of property references #114
Conversation
# Conflicts: # chartlets.js/packages/lib/src/actions/handleHostStoreChange.ts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 92.53% 92.62% +0.09%
==========================================
Files 85 85
Lines 1460 1478 +18
Branches 220 222 +2
==========================================
+ Hits 1351 1369 +18
Misses 91 91
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me. Since we are updating the handleHostStorage.test.ts
, we can also complete the TODO in one of the test? If you agree, you can add it and then merge it, if not just merge it.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. One suggestion, and you can merge it.
* Relaxed requirements for adding new components to Chartlets.js via | ||
plugins. Implementing `ComponentProps` is now optional. (#115) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this from another PR added by mistake here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will follow
Closes #113