Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize computation of property references #114

Merged
merged 7 commits into from
Mar 20, 2025

Conversation

forman
Copy link
Member

@forman forman commented Mar 15, 2025

Closes #113

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.62%. Comparing base (f6118e4) to head (21b115a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
.../packages/lib/src/actions/handleHostStoreChange.ts 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   92.53%   92.62%   +0.09%     
==========================================
  Files          85       85              
  Lines        1460     1478      +18     
  Branches      220      222       +2     
==========================================
+ Hits         1351     1369      +18     
  Misses         91       91              
  Partials       18       18              
Flag Coverage Δ
frontend 84.53% <97.36%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@forman forman requested a review from b-yogesh March 20, 2025 08:00
@forman forman marked this pull request as ready for review March 20, 2025 08:01
Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. Since we are updating the handleHostStorage.test.ts, we can also complete the TODO in one of the test? If you agree, you can add it and then merge it, if not just merge it.

@forman forman requested a review from b-yogesh March 20, 2025 10:20
@forman
Copy link
Member Author

forman commented Mar 20, 2025

PR looks good to me. Since we are updating the handleHostStorage.test.ts, we can also complete the TODO in one of the test?

Done.

Copy link
Collaborator

@b-yogesh b-yogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One suggestion, and you can merge it.

Comment on lines +9 to +11
* Relaxed requirements for adding new components to Chartlets.js via
plugins. Implementing `ComponentProps` is now optional. (#115)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this from another PR added by mistake here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will follow

@forman forman merged commit 53ae761 into main Mar 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache static callback information retrieved from API
2 participants