Skip to content

Add compile step to frontend CI workflows #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Add compile step to frontend CI workflows #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/frontend-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
cache-dependency-path: chartlets.js/package-lock.json

- run: npm ci
- run: npm run compile
- run: npm run lint
- run: npm run test

Expand Down Expand Up @@ -62,7 +63,12 @@ jobs:
run: |
cd chartlets.js
npm install


- name: Lib compile
run: |
cd chartlets.js/packages/lib
npm run compile

- name: Lib lint
run: |
cd chartlets.js/packages/lib
Expand All @@ -77,7 +83,12 @@ jobs:
run: |
cd chartlets.js/packages/lib
npm run build


- name: Demo compile
run: |
cd chartlets.js/packages/demo
npm run compile

- name: Demo lint
run: |
cd chartlets.js/packages/demo
Expand Down
17 changes: 14 additions & 3 deletions .github/workflows/publish-frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
cache-dependency-path: chartlets.js/package-lock.json

- run: npm ci
- run: npm run compile
- run: npm run lint
- run: npm run test

Expand Down Expand Up @@ -56,8 +57,13 @@ jobs:
- name: Install common dependencies
run: |
cd chartlets.js
npm install

npm install

- name: Lib compile
run: |
cd chartlets.js/packages/lib
npm run compile

- name: Lib lint
run: |
cd chartlets.js/packages/lib
Expand All @@ -72,7 +78,12 @@ jobs:
run: |
cd chartlets.js/packages/lib
npm run build


- name: Demo compile
run: |
cd chartlets.js/packages/demo
npm run compile

- name: Demo lint
run: |
cd chartlets.js/packages/demo
Expand Down
3 changes: 2 additions & 1 deletion chartlets.js/packages/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"coverage": "vitest run --coverage",
"build": "tsc && vite build",
"lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"preview": "vite preview"
"preview": "vite preview",
"compile": "tsc"
},
"dependencies": {
"@emotion/react": "^11.13.3",
Expand Down
3 changes: 2 additions & 1 deletion chartlets.js/packages/lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
"coverage": "vitest run --coverage",
"build": "tsc && vite build",
"lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
"preview": "vite preview"
"preview": "vite preview",
"compile": "tsc"
},
"dependencies": {
"micro-memoize": "^4.1.3",
Expand Down