Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Argon2] Use marshalling to avoid copies on little endian platforms #571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zer0x64
Copy link

@zer0x64 zer0x64 commented Oct 7, 2024

Describe your changes

Use Span and marshalling when available to avoid copies when dealing with bytes[] and ulong[] arrays in Argon2. Followup of #559

How has this been tested?

Using the already present Argon2 test suites. I've tested it on net461 and net6.0

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have kept the patch limited to only change the parts related to the patch
  • This change requires a documentation update

See also Contributing Guidelines.

@zer0x64
Copy link
Author

zer0x64 commented Oct 7, 2024

@peterdettman Here's the second part of my Argon2 optimisations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant