Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCMOHAD-23189 LRA EMPI API Changes #1408

Merged
merged 6 commits into from
Feb 15, 2025
Merged

BCMOHAD-23189 LRA EMPI API Changes #1408

merged 6 commits into from
Feb 15, 2025

Conversation

Nikhiljeenru
Copy link
Collaborator

@Nikhiljeenru Nikhiljeenru commented Dec 10, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # BCMOHAD-23189

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

List high-level changes as bullet items

LRA EMPI API Changes and its dependent components and required permission sets added.

Below are some examples

  • Changed field permissions
  • changed field data-type

Deployment Tracker

List all the metadata that is pushed in this commit/PR. Full URL should be fine.
#1408

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@cgijeffolsen cgijeffolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgijeffolsen cgijeffolsen self-requested a review December 11, 2024 18:20
Copy link
Collaborator

@cgijeffolsen cgijeffolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second review completed. approved @Nikhiljeenru @RanadheerRG

@Nikhiljeenru Nikhiljeenru requested review from cgijeffolsen and removed request for cgijeffolsen and RanadheerRG December 11, 2024 23:10
@RanadheerRG RanadheerRG added the on hold Need to get conformation to proceed further label Dec 11, 2024
@Nikhiljeenru Nikhiljeenru removed the on hold Need to get conformation to proceed further label Dec 12, 2024
Copy link
Collaborator

@cgijeffolsen cgijeffolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes will be required later -- this LRA credential will likely be the SAT LRA credential with another one for EDRD LRA credential. Please proceed with testing and demonstration to the business team (Megan/Karen). Approved @Nikhiljeenru @RanadheerRG @NataliaNikishina

Copy link
Collaborator

@RanadheerRG RanadheerRG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @Nikhiljeenru

@NataliaNikishina NataliaNikishina added the on hold Need to get conformation to proceed further label Dec 31, 2024
@NataliaNikishina NataliaNikishina merged commit 9e4de04 into main Feb 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Need to get conformation to proceed further
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants