26471 added App-Name to request headers #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated app name - added app name to Vite config - simplified Vite config - added App Name to Axios requests
|
severinbeauvais
changed the title
severinbeauvais
commented
Mar 17, 2025
| @@ -11,15 +11,14 @@ const appName = JSON.parse(packageJson).appName | |||
| const appVersion = JSON.parse(packageJson).version | |||
| const sbcName = JSON.parse(packageJson).sbcName | |||
| const sbcVersion = JSON.parse(packageJson).dependencies['sbc-common-components'] | |||
| const aboutApp = (appName && appVersion) ? `${appName} v${appVersion}` : 'Unknown APP' | |||
| const aboutSbc = (sbcName && sbcVersion) ? `${sbcName} v${sbcVersion}` : 'Unknown SBC' | |||
There was a problem hiding this comment.
If we can't parse the properties from the package.json file then we have bigger problems, so I simplified this.
severinbeauvais
commented
Mar 17, 2025
| @@ -11,6 +11,7 @@ instance.interceptors.request.use( | |||
|
|
|||
| const kcToken = sessionStorage.getItem(SessionStorageKeys.KeyCloakToken) | |||
| request.headers.common['Authorization'] = `Bearer ${kcToken}` | |||
| request.headers.common['App-Name'] = import.meta.env.APP_NAME | |||
There was a problem hiding this comment.
Sample call to Auth API:
Sample call to Legal API:
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#26471
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).