Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24632 Document Record Service Cont. In Integration #3141

Open
wants to merge 5 commits into
base: feature-drs-integration
Choose a base branch
from

Conversation

flutistar
Copy link
Collaborator

@flutistar flutistar commented Dec 19, 2024

Issue #: /bcgov/entity#24632
Description of changes:

  • Added document_record Service
  • Created upload/delete/download document APIs
  • Added 3 ENV variables
  • Moved pdf validation(max size, encryption) from filing process to document upload
  • Updates business identifier upon pay and approval

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Copy link

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vysakh-menon-aot
Copy link
Collaborator

vysakh-menon-aot commented Dec 20, 2024

Are we moving away from the minio file upload in legal-api? then we need to update COOP file upload (rules and memorandum) in various filings and dissolution and court order file upload.

@flutistar
Copy link
Collaborator Author

Are we moving away from the minio file upload in legal-api? then we need to update COOP file upload (rules and memorandum) in various filings and dissolution and court order file upload.

Yes, we are replacing Minio with Document Record Service, but for now Continuation In only as a Proof of Concept.

@flutistar flutistar changed the title 24632 create upload document 24632 Document Record Service Cont. In Integration Jan 10, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Copy link

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me sir
Just like the UI side, we will want to think about ways to get this into dev without hindering current workflows, leaving in a feature branch will only get more cumbersome as time goes on!

@flutistar flutistar removed the request for review from vysakh-menon-aot February 5, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants