-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24632 Document Record Service Cont. In Integration #3141
base: feature-drs-integration
Are you sure you want to change the base?
24632 Document Record Service Cont. In Integration #3141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
legal-api/src/legal_api/services/filings/validations/continuation_in.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/continuation_in.py
Outdated
Show resolved
Hide resolved
Are we moving away from the minio file upload in legal-api? then we need to update COOP file upload (rules and memorandum) in various filings and dissolution and court order file upload. |
Yes, we are replacing Minio with Document Record Service, but for now Continuation In only as a Proof of Concept. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me sir
Just like the UI side, we will want to think about ways to get this into dev without hindering current workflows, leaving in a feature branch will only get more cumbersome as time goes on!
Issue #: /bcgov/entity#24632
Description of changes:
document_record
ServiceBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).