24593 Tombstone pipeline - implement conversion (exclude liquidation, invol dissolution, cont out) #3199
Conversation
…dissolution, cont out) Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
chenhongjing
changed the title
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
| EventFilings.CONVDSF_NULL: ['conversion', ('dissolution', 'involuntary')], | ||
| EventFilings.CONVDSL_NULL: 'conversion', # TODO: liquidation | ||
| EventFilings.CONVDSO_NULL: ['conversion', ('dissolution', 'unknown')], | ||
| EventFilings.CONVICORP_NULL: 'conversion', |
There was a problem hiding this comment.
It's problematic to map CONVICORP to the behaviour of IA and update business info because conv_event.effective_dt is null for all. Similar issues for CONVID1 and CONVID2, some don't have trigger_dt for involuntary dissolution stage transition.
| 'identifier': jurisdiction.identifier or 'Not Available', | ||
| 'legal_name': jurisdiction.legal_name or 'Not Available', | ||
| 'tax_id': jurisdiction.tax_id, | ||
| 'incorporation_date': formatted_incorporation_date, | ||
| 'expro_identifier': jurisdiction.expro_identifier, | ||
| 'expro_legal_name': jurisdiction.expro_legal_name, | ||
| 'expro_legal_name': jurisdiction.expro_legal_name or 'Not Available', |
There was a problem hiding this comment.
Use Not Available as default values.
This update is to make sure we display XPRO info in summary only when expro_identifier is available instead of displaying XPRO info all the time (report template reference). However, we never get XPRO businesses in the extract(we can find it somewhere in COLIN db), and expro_legal_name will always be unavailable.
Here is an example.
Signed-off-by: Hongjing Chen <[email protected]>
|
Issue #: /bcgov/entity#24593
Description of changes:
amalgamation_typein db & data model to addunknownenumTesting
The following businesses are loaded in dev and affiliated to account
3446, but some business summaries are not properly displayed before the changes are merged.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).