-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25188 - court order filing added #3203
base: main
Are you sure you want to change the base?
Conversation
'courtOrder': { | ||
'name': 'courtOrder', | ||
'title': 'Court Order', | ||
'codes': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
courtOrder is applicable for all legalTypes https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/services/authz.py#L258. Check what should be the fee code for other legalTypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mihai-QuickSilverDev hey mihai, could you please provide any information on this fee codes
As per the requirement this changes are not enough. Remove courtOrder from here (https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/core/filing.py#L481) to show receipt. |
Fix linting and testing errors |
Quality Gate passedIssues Measures |
@@ -389,9 +389,16 @@ class FilingTitles(str, Enum): | |||
'courtOrder': { | |||
'name': 'courtOrder', | |||
'title': 'Court Order', | |||
'displayName': 'Court Order', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayName
should not be removed. Please revert this.
Issue #: bcgov/entity#25188
Description of changes:
add fee code ("COURT") to back end + whatever processing is needed
also need to configure the outputs
Receipt - Yes
Other outputs - No
Comments in the ledger - Yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).