23714-GCP: Build Notebook Report Job #1747
Merged
+4,244
−1,339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen <[email protected]>
stevenc987
requested review from
eve-git,
shaangill025,
mengdong19,
ozamani9gh,
rarmitag,
flutistar and
EPortman
as code owners
EPortman
reviewed
Mar 7, 2025
| ERROR_EMAIL_RECIPIENTS="op://namex/$APP_ENV/notebook-report/ERROR_EMAIL_RECIPIENTS" | ||
| ENVIRONMENT="op://namex/$APP_ENV/notebook-report/ENVIRONMENT" | ||
|
|
||
| NOTIFY_API_URL="op://API/$APP_ENV/notify-api/NOTIFY_API_URL" |
There was a problem hiding this comment.
Having spaces will cause this to break.
EPortman
reviewed
Mar 7, 2025
| job-name: "notebook-report-sandbox" | ||
| service-account: "[email protected]" | ||
| cloudsql-instances: "" | ||
| run-command: "./run.sh" |
There was a problem hiding this comment.
There is not a sandbox environment for this job
EPortman
reviewed
Mar 7, 2025
| deploy-project-id: "a083gt-test" | ||
| job-name: "notebook-report-test" | ||
| service-account: "[email protected]" | ||
| cloudsql-instances: "" |
There was a problem hiding this comment.
Please update with database cloudsql-instance of test (and prod)
Signed-off-by: Chen <[email protected]>
Signed-off-by: Chen <[email protected]>
|
/gcbrun |
Signed-off-by: Chen <[email protected]>
|
rarmitag
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Updated codes for gcp environment.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).