Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix env var typo and prepend namex before job name #1754

Merged

Conversation

EPortman
Copy link
Collaborator

Issue #, if available:
Values pulled from env need to match what is in the vaults.gcp.env file
https://github.com/bcgov/namex/blob/main/jobs/notebook-report/devops/vaults.gcp.env#L14

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

Copy link
Collaborator

@eve-git eve-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EPortman EPortman merged commit c445d4e into bcgov:main Mar 13, 2025
5 of 6 checks passed
@EPortman EPortman deleted the fix_env_typo_and_prepend_namex_before_job branch March 13, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants