Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

26412 cont_in_magic_link_outputs #1761

Merged
merged 4 commits into from
Mar 17, 2025
Merged

26412 cont_in_magic_link_outputs #1761

merged 4 commits into from
Mar 17, 2025
+7 −113

Conversation

kzdev420
Copy link
Contributor

Issue #, if available: #26412

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

EPortman
EPortman approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@EPortman EPortman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

severinbeauvais
severinbeauvais requested changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide examples of what this code change does. Thanks.

@kzdev420
Copy link
Contributor Author

Please provide examples of what this code change does. Thanks.

Screenshot 2025-03-17 at 1 40 40 PM

@kzdev420
Copy link
Contributor Author

Please provide examples of what this code change does. Thanks.

It will update the Next_Action text.
If FF is True and NR_TYPE is a NEW or Cont_In. the Next_Action should be Check your email for instructions on how to complete your application using this name request.
If not, it should be Use this name request to complete your application by visiting https://www.corporateonline.gov.bc.ca

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

severinbeauvais
severinbeauvais approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification 👍

@EPortman EPortman merged commit 1c29dad into bcgov:main Mar 17, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severinbeauvais severinbeauvais

@EPortman EPortman

@eve-git eve-git

@shaangill025 shaangill025

@stevenc987 stevenc987

@mengdong19 mengdong19

@ozamani9gh ozamani9gh

@rarmitag rarmitag

@flutistar flutistar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kzdev420 @severinbeauvais @EPortman