15674 - Enhancements to the daily PAD invoice email #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
reviewed
Mar 20, 2025
| @@ -1,4 +1,7 @@ | |||
| # Your {{ account_number }}: {{ account_name_with_branch }} account completed ${{ invoice_total }} in transactions during business hours on {{ invoice_process_date }}. | |||
| # This email confirms a recent transaction on you account {{ account_number }}: {{ account_name_with_branch }}. | |||
There was a problem hiding this comment.
This email confirms recent transaction(s) on your* account
Check with Ethan -^
seeker25
reviewed
Mar 20, 2025
| @@ -8,6 +11,10 @@ | |||
|
|
|||
| Your account will be suspended and charged a ${{ nsf_fee }} dishonoured bank instrument fee for every failed payment. | |||
|
|
|||
| Log in to BC Registries and Online Services. | |||
| [Log in to view transaction detail]({{ transaction_url }}) | |||
There was a problem hiding this comment.
transaction details*?
Check with Ethan -^
|
Account Mailer now has a dependency on bcgov/sbc-pay#1929 Small lint issue as well tests/unit/test_worker_queue.py:247:16: F541 f-string is missing placeholders |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#15674
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).