Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26465 - Backend changes to support new EFT refunds #1927

Merged
merged 16 commits into from
Mar 13, 2025
Merged

Conversation

seeker25
Copy link
Collaborator

Issue #:
bcgov/entity#26465
Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

@seeker25 seeker25 marked this pull request as ready for review March 13, 2025 21:02
@seeker25 seeker25 changed the title 26465 - Small backend changes to support new EFT refunds 26465 - Backend changes to support new EFT refunds Mar 13, 2025
Copy link
Collaborator

@ochiu ochiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"refundEmail": "[email protected]",
"comment": "Refund for overpayment",
}
data = payload.to_dict()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this makes it camelCase

Copy link
Collaborator

@Jxio Jxio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seeker25 seeker25 merged commit d0e914a into bcgov:main Mar 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants