26465 - PAY-JOBS - EFT Refund cheque support #1930
Merged
+211
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
commented
Mar 20, 2025
| return f"{current_app.config.get('CGI_AP_DISTRIBUTION')}{cls.EMPTY:<16}" | ||
| case EjvFileType.EFT_REFUND: | ||
| case APFlow.EFT_TO_CHEQUE | APFlow.EFT_TO_EFT: |
There was a problem hiding this comment.
Need same GL for EFT regardless if it's cheque or not
seeker25
commented
Mar 20, 2025
| return f"{current_app.config.get('BCA_SUPPLIER_LOCATION'):<3}" | ||
| case EjvFileType.REFUND: | ||
| case APFlow.ROUTING_SLIP_TO_CHEQUE | APFlow.EFT_TO_CHEQUE: |
There was a problem hiding this comment.
Need the supplier override for cheque
seeker25
commented
Mar 20, 2025
| return f"{current_app.config.get('BCA_SUPPLIER_NUMBER'):<30}" | ||
| case EjvFileType.REFUND: | ||
| case APFlow.ROUTING_SLIP_TO_CHEQUE | APFlow.EFT_TO_CHEQUE: |
There was a problem hiding this comment.
Need the supplier override for cheque
seeker25
commented
Mar 20, 2025
| return f"{current_app.config.get('BCA_SUPPLIER_NUMBER'):<9}" | ||
| case EjvFileType.REFUND: | ||
| case APFlow.ROUTING_SLIP_TO_CHEQUE | APFlow.EFT_TO_CHEQUE: |
There was a problem hiding this comment.
Need the supplier override for cheque
|
Will do side by side comparison with old code vs new code tomorrow with prod secrets |
|
Side by side passed, looks the same for EFT -> EFT and routing slip -> CHEQUE (except for immediate) |
ochiu
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#26465
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).