-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Update FE to match BE DTO updates #514
Conversation
3e43fac
to
033776b
Compare
bc62a04
to
dab2825
Compare
9673810
to
ed35cf0
Compare
fbec363
to
35f0674
Compare
I think you said this should address https://emcr.atlassian.net/browse/TC-971 but it doesn't seem to. Not that I think its particularly important |
Certification expiry not adding |
Oh sorry! I mixed that up with something else - on BCWS setting the 1st,2nd,3rd to none is not working. I'll do a fix for the choice order (thinking we just disable 2nd/3rd choice if first is not set, and disable 3rd if 2nd is not set?) |
d3e2605
to
815df17
Compare
should be resolved |
should be resolved |
1b581dc
to
a3258ae
Compare
a3258ae
to
8e54ccd
Compare
|
Still not working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but certificate expiry still not adding on
.email('Invalid email format.') | ||
.matches( | ||
/^[^\s@][email protected]+$/, | ||
'Invalid email format. Must be a gov.bc.ca email address.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double check this with Alexis. We've come to find some valid non gov emails in the system, that have IDIRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - can we do this on a separate PR since this is functionality is currently in place already? (Just to get this one merged in/tested)
CHORE
Objective: