Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Update FE to match BE DTO updates #514

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

chelsea-EYDS
Copy link
Collaborator

CHORE

Objective:

@chelsea-EYDS chelsea-EYDS force-pushed the CHELSEA-DTO-FE branch 2 times, most recently from 3e43fac to 033776b Compare February 13, 2025 05:14
@bcgov bcgov deleted a comment from sonarqubecloud bot Feb 13, 2025
@bcgov bcgov deleted a comment from sonarqubecloud bot Feb 13, 2025
@chelsea-EYDS chelsea-EYDS force-pushed the CHELSEA-DTO-FE branch 5 times, most recently from fbec363 to 35f0674 Compare February 13, 2025 07:47
@fw-noel
Copy link
Collaborator

fw-noel commented Feb 14, 2025

I think you said this should address https://emcr.atlassian.net/browse/TC-971 but it doesn't seem to. Not that I think its particularly important

@fw-noel
Copy link
Collaborator

fw-noel commented Feb 14, 2025

Certification expiry not adding

@fw-noel
Copy link
Collaborator

fw-noel commented Feb 14, 2025

Screenshot 2025-02-13 at 4 59 51 PM

@chelsea-EYDS
Copy link
Collaborator Author

I think you said this should address https://emcr.atlassian.net/browse/TC-971 but it doesn't seem to. Not that I think its particularly important

Oh sorry! I mixed that up with something else - on BCWS setting the 1st,2nd,3rd to none is not working. I'll do a fix for the choice order (thinking we just disable 2nd/3rd choice if first is not set, and disable 3rd if 2nd is not set?)

@chelsea-EYDS chelsea-EYDS marked this pull request as ready for review February 14, 2025 01:35
@chelsea-EYDS chelsea-EYDS requested a review from fw-noel February 14, 2025 02:44
@chelsea-EYDS
Copy link
Collaborator Author

Certification expiry not adding

should be resolved

@chelsea-EYDS
Copy link
Collaborator Author

I think you said this should address https://emcr.atlassian.net/browse/TC-971 but it doesn't seem to. Not that I think its particularly important

should be resolved

@chelsea-EYDS
Copy link
Collaborator Author

Screenshot 2025-02-13 at 4 59 51 PM

removed :)

Base automatically changed from CHELSEA-DTO-BE to CHELSEA-DTO February 14, 2025 02:49
@fw-noel
Copy link
Collaborator

fw-noel commented Feb 14, 2025

Certification expiry not adding

should be resolved

Still not working!

Copy link
Collaborator

@fw-noel fw-noel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but certificate expiry still not adding on

.email('Invalid email format.')
.matches(
/^[^\s@][email protected]+$/,
'Invalid email format. Must be a gov.bc.ca email address.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should double check this with Alexis. We've come to find some valid non gov emails in the system, that have IDIRs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - can we do this on a separate PR since this is functionality is currently in place already? (Just to get this one merged in/tested)

@chelsea-EYDS chelsea-EYDS merged commit f0bce38 into CHELSEA-DTO Feb 14, 2025
5 checks passed
@chelsea-EYDS chelsea-EYDS deleted the CHELSEA-DTO-FE branch February 14, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants