Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.1.0 #24

Merged
merged 180 commits into from
Aug 12, 2024
Merged

Release/v0.1.0 #24

merged 180 commits into from
Aug 12, 2024

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Aug 6, 2024

Release/v0.1.0

First release of merged pori_ipr_python and pori_graphkb_python packages as pori_python.

Improvement:

  • merge pori_ipr_python and pori_graphkb_python adaptors
  • update test suite for use with external PORI deployments; skip tests that will only work on the BCGSC PORI deployment (where possible, replace with tests on other data)
  • DEVSU-2348: add function to fetch associated gene list per variant returned by cancer predisposition and pharmacogenomic gene variant functions
  • DEVSU-2349: add option to load reports by pori-ipr-api reports-async endpoint
  • SDEV-4409: update gene exclude lists
  • SDEV-4409: use typing extension > 4.4; remove max version on requests
  • KBDEV-1231: add test to ensure no incorrect matches to wildtype

Bugfix:

  • DEVSU-2348: fix test of pharmocogenomic gene list
  • SDEV-4409: use tqdm for progress bar
  • SDEV-4431: update mypy types

…ugfix/DEVSU-2348-add-gene-assoc-to-pharmacogenelist
…pharmacogenelist

Bugfix/devsu 2348 add gene assoc to pharmacogenelist
…eature/DEVSU-2349-add-async-report-loading
@elewis2 elewis2 marked this pull request as ready for review August 6, 2024 21:13
@dustinbleile
Copy link
Contributor

I might just go with Release v1.0.0 unless you have some other big milestone in mind.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.78669% with 127 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c1c0e04). Learn more about missing BASE report.

Files Patch % Lines
pori_python/ipr/connection.py 27.27% 40 Missing ⚠️
pori_python/ipr/main.py 60.22% 35 Missing ⚠️
pori_python/ipr/annotate.py 50.84% 29 Missing ⚠️
pori_python/ipr/inputs.py 86.51% 12 Missing ⚠️
pori_python/graphkb/util.py 90.62% 3 Missing ⚠️
pori_python/ipr/util.py 89.65% 3 Missing ⚠️
pori_python/ipr/ipr.py 96.15% 2 Missing ⚠️
pori_python/ipr/summary.py 97.82% 2 Missing ⚠️
pori_python/graphkb/genes.py 98.27% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   86.23%           
=======================================
  Files           ?       18           
  Lines           ?     2157           
  Branches        ?        0           
=======================================
  Hits            ?     1860           
  Misses          ?      297           
  Partials        ?        0           
Flag Coverage Δ
unittests 86.23% <80.78%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dustinbleile
Copy link
Contributor

We'll need some other reviewers, if we are to do a release

@mathieulemieux
Copy link
Member

We'll need some other reviewers, if we are to do a release

right @dustinbleile, I'm on it!

@dustinbleile
Copy link
Contributor

We just need one of the reviewers to approve so this can be merged.

@elewis2 elewis2 merged commit 016eac1 into main Aug 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants