Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KBDEV-1236 #25

Merged
Merged

Conversation

mathieulemieux
Copy link
Member

Added extra type checking for variant matching

@mathieulemieux mathieulemieux self-assigned this Aug 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.04%. Comparing base (303c611) to head (d4781cd).

Files with missing lines Patch % Lines
pori_python/graphkb/match.py 65.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #25      +/-   ##
===========================================
- Coverage    86.25%   86.04%   -0.21%     
===========================================
  Files           18       18              
  Lines         2160     2179      +19     
===========================================
+ Hits          1863     1875      +12     
- Misses         297      304       +7     
Flag Coverage Δ
unittests 86.04% <65.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dustinbleile
dustinbleile previously approved these changes Aug 20, 2024
dustinbleile
dustinbleile previously approved these changes Sep 24, 2024
pori_python/graphkb/match.py Outdated Show resolved Hide resolved
@mathieulemieux mathieulemieux merged commit 3fae486 into develop Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants