Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/devsu 2477 filter gkb matches #37

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

mathieulemieux
Copy link
Member

@mathieulemieux
Copy link
Member Author

Here are some before/after filtering counts:

/projects/POG/POG_data_hg38_no_alt/POG1858/gsc_report/gsc_report-13.0.0/genomic/F145899_F145808_F145970/ipr_report.json
before: 144
after: 115
/projects/POG/POG_data_hg38_no_alt/POG1868/gsc_report/gsc_report-13.0.0/genomic/F146248_F145962_F146348/ipr_report.json
before: 597
after: 569
/projects/POG/POG_data_hg38_no_alt/POG1911/gsc_report/gsc_report-13.0.0/genomic/F147930_F147420_F148116/ipr_report.json
before: 222
after: 205

@mathieulemieux mathieulemieux changed the base branch from main to develop October 29, 2024 00:17
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (e4689df) to head (2832eb5).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #37      +/-   ##
===========================================
+ Coverage    86.04%   86.15%   +0.10%     
===========================================
  Files           18       18              
  Lines         2179     2196      +17     
===========================================
+ Hits          1875     1892      +17     
  Misses         304      304              
Flag Coverage Δ
unittests 86.15% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathieulemieux
Copy link
Member Author

I'll post comparisons for wildtypes tomorrow

@mathieulemieux
Copy link
Member Author

mathieulemieux commented Nov 8, 2024

/projects/POG/POG_data_hg38_no_alt/POG1868/gsc_report/gsc_report-13.0.0/genomic/F146248_F145962_F146348/ipr_report.json

before:

  • 597

after:

  • if wildtype are taken into account: 569
  • if we do not take them into account when filtering: 577

2 unique statements affected:

@mathieulemieux mathieulemieux marked this pull request as ready for review November 8, 2024 16:27
@mathieulemieux mathieulemieux self-assigned this Nov 8, 2024
@mathieulemieux
Copy link
Member Author

When pori_python & ipr_api dev get fixed, I'll be able to generate comparative genomic reports.

@elewis2 elewis2 merged commit 0efbfaa into develop Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants