Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/devsu 2349 add async report loading #4

Merged
merged 11 commits into from
Jul 9, 2024

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Jul 8, 2024

Adds option to upload reports asynchronously, setting the number of mins the outcome should be waited for. Default is five minutes (plus an initial 3 minutes of checks with shorter times between them).

Option to use async and number of minutes to wait is settable in upload_report and ipr.main.

@elewis2 elewis2 requested a review from dustinbleile July 8, 2024 23:44
@elewis2 elewis2 requested review from calchoo and Nithriel July 8, 2024 23:48
Nithriel
Nithriel previously approved these changes Jul 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 86.17%. Comparing base (cdf775f) to head (0e0aa5c).

Files Patch % Lines
pori_python/ipr/connection.py 13.79% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop       #4      +/-   ##
===========================================
- Coverage    87.13%   86.17%   -0.96%     
===========================================
  Files           19       19              
  Lines         2129     2156      +27     
===========================================
+ Hits          1855     1858       +3     
- Misses         274      298      +24     
Flag Coverage Δ
unittests 86.17% <16.66%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elewis2 elewis2 requested a review from Nithriel July 9, 2024 20:54
@elewis2 elewis2 merged commit 9cd1b3d into develop Jul 9, 2024
8 checks passed
@elewis2 elewis2 deleted the feature/DEVSU-2349-add-async-report-loading branch July 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants