Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/unexpected state on success #9

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Jul 11, 2024

Changes check on whether report has loaded in reports-async to look for presence of an 'ident' field instead of checking the 'state' field (which can contain states from bullmq about the status of the report loading process, or can contain states about the report creation and review process).

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.18%. Comparing base (215bf83) to head (d785a1a).

Files Patch % Lines
pori_python/ipr/connection.py 31.57% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop       #9   +/-   ##
========================================
  Coverage    86.18%   86.18%           
========================================
  Files           19       19           
  Lines         2157     2157           
========================================
  Hits          1859     1859           
  Misses         298      298           
Flag Coverage Δ
unittests 86.18% <31.57%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dustinbleile dustinbleile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do a single black or ruff linting commit?

@elewis2
Copy link
Collaborator Author

elewis2 commented Jul 12, 2024

Should we do a single black or ruff linting commit?

yes, sounds good to me!

@elewis2 elewis2 closed this Jul 12, 2024
@elewis2 elewis2 reopened this Jul 12, 2024
@dustinbleile dustinbleile merged commit a15f56e into develop Jul 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants