Enable HTTP Verb in Routing

[pveyes]

Using array in config/routes.php for HTTP Verb. HTTP Verb is case-insensitive

e.g:
$route['(:any)']['POST'] = "controller/any_post_method";
$route['path']['get'] = "controller/path_get_method";
$route['path']['(:any)'] = "controller/path_any_method";

Using (:any) or not using http verb at all will produce same result
e.g: $route['path']['(:any)'] is the same as $route['path']

So it won't break any existing routes

[narfbg]

You should first check if $this->routes[$uri] exists and then have the other conditions depending on it, i.e.:

if (isset($this->routes[$uri]))
{
    if (is_string($this->routes[$uri]))
    {
        // regular route code
    }
    elseif (is_array($this->routes[$uri]) && isset($this->routes[$uri][$http_verb]))
    {
        // verb route code
    }
    ...
}

[narfbg]

(:any) is a pseudo-regexp token that is only intended to be used with regular expression routes, it doesn't make sense to use it for request methods. And why do you need to do that anyway?

Also, this feature requires proper documentation and a changelog entry.

[pveyes]

Thanks for your feedback. Sorry, should've read that more thoroughly.

Actually (:any) is optional, it behaves the same as using nothing so you can remove it. I just thought that user may be confused with new routing with http verb, so (:any) will show that the route accept any http verb. I use (:any) because in the existing routing (:any) is like a keyword for anything.

I'll try fixing my code and give more proper documentation

[a-h-abid]

I was wondering if things can be done in the other way around. I mean, put them like this

$route['some/page'] = array('verb'=>'get');
$route['some/other/page'] = array('verb'=>'post');

This way, it will be easy to target in code. plus if plan to merge with this reverse route method with some modification, things will go nicely. Also any additions can be done easily I think.

I'm using that reverse route in one of my application i'm developing. With changes to the index keys to string, I can check which controller it wants to use and get its alias name.

$route['some/page'] = array('uses' => 'Controller/method', 'as' => 'somepage');

I believe this is one of the main feature of CI3. #218 . Isn't It?

[narfbg]

No, this wouldn't be convenient in terms of usage.

And no, reverse routing isn't a "main" feature, it's a non-existent feature. The tag on that issue just says that it's a feature request. Ignore it, even if it gets implemented at some point we don't need to worry about it now.

[CMCDragonkai]

I use the Pigeon library to handle this. Perhaps that can be integrated? I find it's hierarchical routes rather useful. https://github.com/jamierumbelow/pigeon