build: tailwind upgrade v3 → v4#552
Open
libby-correctiv wants to merge 13 commits into
Open
Conversation
still to do - fix stripepaymentform appearance object review form renderer changes
libby-correctiv
force-pushed
the
build/tailwind-upgrade
branch
from
a24e912 to
91465c5
Compare
libby-correctiv
changed the title
libby-correctiv
changed the title
wpf500
reviewed
May 13, 2026
Member
wpf500
left a comment
wpf500
left a comment
There was a problem hiding this comment.
This is a really great PR, very thorough and clean and you've found good solutions for all the problems.
I found just two visual regressions when I looked:
AppButtonGroup: it seems to work in Histoire but not in the frontend itself. Note in the screenshot that the button borders don't align.
Doesn't work:
Works:
- The dialog in the form builder has too much spacing. This one is strange and I couldn't really figure out what was happening.
Too much spacing:
Correct spacing
--
Do you know what the button group one could be about? I wonder if the group-btns styling isn't being applied in the frontend for some reason.
| --text-3_5xl: 2rem; | ||
|
|
||
| /* Transition properties??? i cant see where this is used */ | ||
| --transition-width: width; |
Member
There was a problem hiding this comment.
Hmm this one is strange. Where did this come from?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Upgrade Tailwind to v4
Describe your changes
tailwind.config.jstotailwind.css!importantflags in@applyutilities to!@referencetoindex.cssin CSS Modules and<style>blocksStripePaymentFormto use new tw CSS variables and delete oldtheme.js(previous workaround to get tw custom theme classes into Stripe iframe)Checklist before requesting a review
yarn checkand addressed any problemsChecklist before merging