Skip to content

Improve open api schema population #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leinnan wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Improve open api schema population #4443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
886c6dd
OpenAPI- improve schema generation
Leinnan Dec 9, 2025
2b412c7
Improved OpenAPI components schema gen
Leinnan Dec 9, 2025
7a583ea
Reduce code repetition
Leinnan Dec 9, 2025
a8e5a20
Simplify code
Leinnan Dec 9, 2025
81d9cee
Fix code doc
Leinnan Dec 9, 2025
d7cdee0
Merge remote-tracking branch 'origin/main' into feature/improveOpenAp…
Leinnan Jan 14, 2026
2c349e0
improvements, more tests
Leinnan Jan 15, 2026
5fbd62d
Improvements, part 2
Leinnan Jan 15, 2026
bd542a7
Generate schemas for content references
Leinnan Jan 15, 2026
b14634f
Working version
Leinnan Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/beamable.common/Runtime/CronExpression/ExpressionParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ bool ValidateMinValue(int value)
/// Converts schedule definition into cron expression
/// </summary>
/// <param name="scheduleDefinition">Schedule definition</param>
/// <returns>The cron expression<returns>
/// <returns>The cron expression</returns>
public static string ScheduleDefinitionToCron(ScheduleDefinition scheduleDefinition)
{
var second = ConvertToCronString(scheduleDefinition.second);
Expand Down
7 changes: 6 additions & 1 deletion cli/cli/Services/UnrealSourceGenerator/UnrealSourceGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2396,7 +2396,12 @@ private static UnrealType GetUnrealTypeForField(out UnrealType nonOverridenType,
: UNREAL_MAP + $"<{UNREAL_STRING}, {dataType}>");
}
case ("object", _, _, _) when schema.Reference == null && !schema.AdditionalPropertiesAllowed:
throw new Exception("Object fields must either reference some other schema or must be a map/dictionary!");
if (parentDoc.Components.Schemas.TryGetValue(schema.Title, out var innerSchema) || parentDoc.Components.Schemas.TryGetValue( Uri.EscapeDataString(schema.Title), out innerSchema))
{
return GetUnrealTypeForField(out nonOverridenType, context, parentDoc, innerSchema, fieldDeclarationHandle, flags);
}
throw new Exception(
"Object fields must either reference some other schema or must be a map/dictionary!");
case ("array", _, _, _):
{
var isReference = schema.Items.Reference != null;
Expand Down
Loading
Loading