Update address.rs

[syed-ghufran-hassan]

This test verifies that only valid addresses are returned.

[PsypherPunk]

It looks like tests are failing due to the ordering of results:

assertion `left == right` failed
  left: [10.0.0.1, 192.168.1.1]
 right: [192.168.1.1, 10.0.0.1]

I think this is down to the fact we use a BTreeSet in parse_addresses (to remove duplicates) which means the input order may not match the output. You could update your test such that it doesn't assume the input order…?

Also, could you run cargo fmt as the GitHub diff suggests there's some indentation/line-breaks missing.

[syed-ghufran-hassan]

Noted I will modify sir.

…

On Mon, Feb 3, 2025 at 8:57 PM Roger G. Coram ***@***.***> wrote: It looks like tests are failing due to the ordering of results: assertion `left == right` failed left: [10.0.0.1, 192.168.1.1] right: [192.168.1.1, 10.0.0.1] I *think* this is down to the fact we use a BTreeSet in parse_addresses (to remove duplicates) which means the input order may not match the output. You could update your test such that it doesn't assume the input order…? Also, could you run cargo fmt as the GitHub diff suggests there's some indentation/line-breaks missing. — Reply to this email directly, view it on GitHub <#740 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEZRWUK6ZX5QDB2UVR6CRAT2N6GVDAVCNFSM6AAAAABWDVZCJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZRGQYDIOJVGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>