Conversation
|
Wow it's been a year and I didn't see this. @not-night-but Could you make a new PR in the tabulator repo instead? |
|
Whether the main tabulator is still active or not, I think this PR needs to be in the main repo so we don't forget later when we don't use the fork anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a couple formatters, we use
isNaN, but this forces a conversion that can fail (BigInt throws an error when being passed to this function, and it causes issues).Number.isNaNdoes not force a conversion, and it properly determines whether or not a BigInt is a number, so I say we use this instead at least for the formatters