fix overflowing menu#9
Closed
azmy60 wants to merge 11 commits into
Closed
Conversation
…#4219, tabulator-tables#4525) - fix horizontal scrollbar showing on initial display when there are groups - fix tableholder not scrolling to bottom when there are groups - fix tableholder jumping to top every time a group is collapsed/expanded Implements Group.calcHeight() so group row height is non-zero, and re-runs GroupRows.virtualRenderFill() on table-layout so minWidth is recalculated after fitColumns has scaled the columns. fixes tabulator-tables#4219 fixes tabulator-tables#4525
Author
|
NOTE: this doesn't need e2e test. |
…bles#4219, tabulator-tables#4525) Covers the two headline symptoms fixed by this PR: - tabulator-tables#4219: virtual-DOM scroll never reaches the bottom with many collapsed groups - tabulator-tables#4525: expanding a group below the fold resets the scroll position to the top Both require a real browser (group rows report a zero height only after layout), so they live in the Playwright e2e suite. Verified red without the fix and green with it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…oupScrollErrors_clean fix: scrolling errors when all groups are collapsed (tabulator-tables#4219, tabulator-tables#4525)
This condition is always true because of the initialize method
…rinking-group-rows Fix shrinking group rows
(cherry picked from commit c4ac9c5)
Popup._fitToScreen now flips a popup upward when it would overflow the container bottom, anchoring the menu's bottom to the container when a flip-up would push it past the top edge. Only falls back to the full-height + scroll behavior when the menu itself is taller than the container, which avoids stretching the menu across the viewport for mid-screen triggers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> (cherry picked from commit c7e1321)
Author
|
Replaced by #10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beekeeper-studio/beekeeper-studio#4241