Add haptic feedback toggle for code refresh #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbakker
requested changes
Jan 24, 2025
app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/EntryListView.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/helpers/VibrationHelper.java
Outdated
Show resolved
Hide resolved
michaelschattgen
force-pushed
the
feature/haptic-feedback
branch
3 times, most recently
from
42ea9df to
79c6fdc
Compare
alexbakker
requested changes
May 4, 2025
There was a problem hiding this comment.
I see that the fix for the animation-related crash for entries that have a period of 7 is not included here. Do you want to create a separate PR for that?
| @@ -144,12 +147,26 @@ public int getSpanSize(int position) { | |||
| @Override | |||
| public void onRefresh() { | |||
| refresh(false); | |||
|
|
|||
| if (_recyclerView.isShown()) { | |||
There was a problem hiding this comment.
Do we still need this check now that we stop the refresher when the activity is not visible?
| _refresher.stop(); | ||
| } | ||
|
|
||
| public void onRefreshStart() { |
There was a problem hiding this comment.
Since we're now unconditionally starting the refresher from MainActivity, I think we need to check whether _adapter.getMostFrequentPeriod() returns -1 here and if so not start the refresher. Otherwise, this causes a tight loop in the refresher in case there are no entries in the vault yet. This is also the reason why the instrumented tests are failing.
Improve haptic feedback logic
michaelschattgen
force-pushed
the
feature/haptic-feedback
branch
from
79c6fdc to
63d2666
Compare
alexbakker
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to enable/disable haptic feedback when the codes are about to expire or when they refresh.