Fix lrclib lyrics #5406
Open
Fix lrclib lyrics #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snejus
force-pushed
the
fix-lrclib-lyrics
branch
2 times, most recently
from
d4bed72
to
829192d
Compare
snejus
force-pushed
the
fix-lrclib-lyrics
branch
5 times, most recently
from
cb8929f
to
c2807f0
Compare
|
The build on I will address this in a separate PR and rebase this one accordingly once the fix is merged. Note: this issue popped up now because I added a new |
bal-e
reviewed
Sep 5, 2024
snejus
added a commit
that referenced
this pull request
Sep 8, 2024
…5407) See my comment under #5406 for context > The build on win32 is failing to install reflink because it's [only supported until Python 3.7](https://gitlab.com/rubdos/pyreflink/-/blob/master/setup.py?ref_type=heads). > > I will address this in a separate PR and rebase this one accordingly once the fix is merged. > > Note: this issue popped up now because I added a new requests-mock dependency which invalidated cached dependencies.
snejus
force-pushed
the
fix-lrclib-lyrics
branch
from
c2807f0
to
64c0439
Compare
snejus
force-pushed
the
fix-lrclib-lyrics
branch
3 times, most recently
from
dc02c94
to
622ed3c
Compare
snejus
force-pushed
the
fix-lrclib-lyrics
branch
from
622ed3c
to
3eb04ba
Compare
bal-e
reviewed
Sep 19, 2024
Adjust the base URL to perform a '/search' instead of attempting to '/get' specific lyrics where we're unlikely to find lyrics for the specific combination of album, artist, track names and the duration (see https://lrclib.net/docs). Since we receive an array of matching lyrics candidates, rank them by their duration similarity to the item's duration, and whether they contain synced lyrics.
Create 'helpers.ConfigMixin' which sets up testing configuration. This is helpful for tests (e.g. test_lyrics.py) that only need the configuration and do not require temp dir. (#5102) Refactor lyrics tests to fix the issue global beets config issue. Additionally, add 'integration_test' mark that can be used to mark tests that should only run once a week.
Improve requests performance with requests.Session which uses connection pooling for repeated requests to the same host. Additionally, this centralizes request configuration, making sure that we use the same timeout and provide beets user agent for all requests.
Due to request error handling this logic will only run for successful requests, so we can safely assume the html to be a string.
Tidy up 'Google.is_page_candidate' method and remove 'Google.sluggify' method which was a duplicate of 'slug'. Since 'GeniusFetchTest' only tested whether the artist name is cleaned up (the rest of the functionality is patched), remove it and move its test cases to the 'test_slug' test.
snejus
force-pushed
the
fix-lrclib-lyrics
branch
2 times, most recently
from
1ff3ff2
to
4d481d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5102
Fixes #5133
LRCLib
Adjust the base URL to perform a
/searchinstead of attempting to/getspecific lyricswhere we're unlikely to find anything for some specific combination of album, artist and
title fields.
Since we receive an array of matching lyrics candidates, rank them by
and pick the best match.
Additionally, I did a small refactor of lyrics integration tests and removed some unused lyrics files.