Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello y'all, when working on the importer.py file in a previous PR I noticed that this file grew quite large and badly needs a restructuring. Restructuring should improve our ability to apply changes to it in the future and isolate sub-functionalities within the importer.
Overview
For now I only changed the structure keeping the code (mostly) unchanged.
I split the functions and classes in the importer.py into the following responsibilities:
importer/session.py
: Includes theImportSession
class.importer/stages.py
: Includes all stage functions, I prefixed the helper functions with a_
to allow distinguishing between stages and helper functions more easily.importer/state.py
: Includes the logic for theImportState
handling i.e. the resume feat.importer/tasks.py
: Includes theImportTask
class and all derived classes. Also includes theAction
enum which I have renamed fromaction
.importer/__init__.py
: Identified all public facing classes and functions and added them to__all__
Potential future changes
I don't want to add this to this PR but there are some places here where I see possible improvements for our code:
Am happy to tackle some of these issues in future PRs if you also think they are worth it.
Best,
Sebastian
Note: This PR is based on #5611 and can only be merged once the typing additions are accepted.