Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbsync / missing plugins: consider all metadata backends #5636

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

snejus
Copy link
Member

@snejus snejus commented Feb 16, 2025

This PR adds support for alternate metadata backends in the mbsync and missing plugins, allowing them to work with any metadata backend the items are tagged with instead of being limited to just MusicBrainz.

Key changes:

  • Removed redundant albums_for_id and items_for_id methods.
  • Updated album_for_id and track_for_id implementations to return a single album/track as their names suggest.
  • Updated both plugins to use the above functions instead of MusicBrainz-specific ones.
  • Updated missing plugin docs to make it clear that missing albums for artists can only be obtained for the musicbrainz metadata backend
    • This is possible with other backends but implementation was outside of this PR's scope.
    • Slightly simplified the existing implementation

The changes maintain backwards compatibility while enabling users to leverage metadata from sources like Deezer, Discogs or Bandcamp when syncing their libraries.

Note: this change came about because I'm working on making musicbrainz a separate plugin: this will be submitted in the next PR.

@snejus snejus requested review from wisp3rwind and JOJ0 February 16, 2025 12:41
@snejus snejus changed the title \mbsync\ / \missing\ plugins: consider all metadata backends mbsync / missing plugins: consider all metadata backends Feb 16, 2025
@snejus snejus force-pushed the missing-mbsync-consider-all-data-sources branch from 85a442f to 46e822e Compare February 17, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant