mbsync
/ missing
plugins: consider all metadata backends
#5636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for alternate metadata backends in the
mbsync
andmissing
plugins, allowing them to work with any metadata backend the items are tagged with instead of being limited to just MusicBrainz.Key changes:
albums_for_id
anditems_for_id
methods.album_for_id
andtrack_for_id
implementations to return a single album/track as their names suggest.missing
plugin docs to make it clear that missing albums for artists can only be obtained for themusicbrainz
metadata backendThe changes maintain backwards compatibility while enabling users to leverage metadata from sources like Deezer, Discogs or Bandcamp when syncing their libraries.
Note: this change came about because I'm working on making
musicbrainz
a separate plugin: this will be submitted in the next PR.