-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEP-0006 - Gene Modifications #13
base: master
Are you sure you want to change the base?
Conversation
Add more explanation on how gmod is used in geneAbundance
What about genomic modifications that are not directly attributable to a gene (e.g. a SNP)? Can we come up with a way to capture both genomic and gene modifications that are impactful? |
Here's an example when we encoded a variant (with minimal information about actually what it is, that we hope we could look up from dbSNP later)
Otherwise, I don't see why we can't refer to SNPs with the |
|
From my understanding of Semantic Versioning the extension of BEL specification with a new function like gmod obligatorily needs an increase in the MINOR version number to 2.1.0 and not 2.0.0.+ (perhaps this was the meaning of the plus?). I suggest also, that BEL should try to follow strictly the NAMESPACE:NAME convention without another set of arguments for a new function. |
Hi Christian,
I proposed using the 2.0.0+ in order to not determine specifically that a feature will go into a minor release or a major release. I agree that gmod() is a minor release feature - it does not mean that we will bundle it into something that is backwards compatible which would require a major release. Also, BEP’s are not handled in order so saying that it should be 2.1.0 is misleading as it may wind up in 2.3.0 for example.
What we need to describe in that part of the BEP is: Is this backwards compatible? Does it target a specific version of BEL? 2.0.0+ indicates it targets versions beyond 2.
Thanks for reviewing it - hope this clarifies our thinking a little bit more. Please feel free to add a Pull Request to the BEP Template to make this clearer to you and others.
Wm
… On Aug 6, 2018, at 2:27 AM, Christian Ebeling ***@***.***> wrote:
From my understanding of Semantic Versioning <https://semver.org/> the extension of BEL specification with a new function like gmod obligatorily needs an increase in the MINOR version number to 2.1.0 and not 2.0.0.+ (perhaps this was the meaning of the plus?). I suggest also, that BEL should try to follow strictly the NAMESPACE:NAME convention without another set of arguments for a new function.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWS9_DuxgsiGr4p07L-wduAlE5s0YqBks5uN-HGgaJpZM4VSuBB>.
|
Relevant proposal from HGVS: http://varnomen.hgvs.org/bg-material/consultation/svd-wg005/ |
Discussion NotesHow much of a gene is modified, and in what position? HGVS has an open issue for methylation (see https://varnomen.hgvs.org/recommendations/open-issues/). Seems like we'd have our own syntax for this one. Idea: add a range as a second optional argument Other thing to think about: what about the promoter? X binds promoter of Y and X increases expression of Y -> X is a transcription factor of Y John mentions: contact stuff? What rules should there be for gene modifications? Things that are localized to a certain gene. If it's global, there's probably a GO process describing it. Can we show that this gene region is equivalent to the gene's promoter? TODO: different scenarios for locations, ranges, and specific parts like promoter. |
This BEP proposes an addition to the BEL 2.0+ syntax to support gene modifications (
gmod()
)The full text can be found at: https://github.com/belbio/bep/blob/bep-0006/docs/drafts/BEP-0006.md