[beman-tidy] Implement LICENSE.APACHE_LLVM #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neatudarius
reviewed
Jul 18, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
LGTM overall, but let's apply some tweaks
tools/beman-tidy/tests/lib/checks/beman_standard/license/test_license.py
Outdated
Show resolved
Hide resolved
tools/beman-tidy/tests/lib/checks/beman_standard/license/test_license.py
Outdated
Show resolved
Hide resolved
tools/beman-tidy/tests/lib/checks/beman_standard/license/data/valid/valid-LICENSE-v1
Show resolved
Hide resolved
tools/beman-tidy/tests/lib/checks/beman_standard/license/test_license.py
Outdated
Show resolved
Hide resolved
tools/beman-tidy/tests/lib/checks/beman_standard/license/test_license.py
Outdated
Show resolved
Hide resolved
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
neatudarius
approved these changes
Jul 18, 2025
tools/beman-tidy/beman_tidy/lib/checks/beman_standard/license.py
Outdated
Show resolved
Hide resolved
vickgoodman
requested review from
JeffGarland,
ednolan,
rishyak and
wusatosi
as code owners
wusatosi
pushed a commit
that referenced
this pull request
Sep 27, 2025
….APACHE_LLVM [beman-tidy] Implement LICENSE.APACHE_LLVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://github.com/bemanproject/infra/pull/135#discussion_r2210507761
Implemented LICENSE.APACHE_LLVM - #55