Removed MIT as a supported license #212

pysojic · 2025-12-25T03:43:44Z

This pull request removes support for the MIT license from the beman-tidy repository.

Changes included:

Removed MIT from the list of supported/recognized licenses in the codebase and any associated configuration.
Updated documentation and/or help text to no longer mention MIT as a supported option.
Adjusted validation, tests, and fixtures accordingly (removing MIT-related test cases and ensuring remaining license paths still behave as expected).

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md

JeffGarland · 2025-12-25T13:16:03Z

@pysojic welcome and thanks for the PR! Most of this looks fine to me, but there's a couple stray changes as noted that don't seem right. We'll see what others think.

ednolan · 2025-12-26T21:11:15Z

Approved. @JeffGarland -- ignore those apparent stray changes -- this repository includes copies of exemplar's README.md file as unit test data, and the "changes" git is picking up are mostly just caused by differences in the version of exemplar from which the README.md was copied.

neatudarius · 2025-12-26T21:58:08Z

Hello! Thanks @pysojic and welcome to Beman!

As a context for @bemanproject/project-leads , Pierre is a student and I will mentor him to contribute to Beman. Things might not be perfect or expected from first PRs, I will handle the onboard.

TLDR: You can ignore this PR for the moment. CC: @ednolan @JeffGarland

neatudarius · 2025-12-26T21:59:31Z

Approved. @JeffGarland -- ignore those apparent stray changes -- this repository includes copies of exemplar's README.md file as unit test data, and the "changes" git is picking up are mostly just caused by differences in the version of exemplar from which the README.md was copied.

Agree, we don't need to update these copies. And we definitely don't need to update them in this PR (expect the license related ones).

CC: @ednolan @JeffGarland

neatudarius

Thanks again @pysojic for contributing in Beman!

Your core implementation (inside beman_tidy/lib) it's 100% complete and correct. The updates in the tests/ directory also have changes which are at least out of scope for this PR (and also I think they will decrease our coverage).

Please check my comments:

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md

neatudarius · 2025-12-26T22:06:04Z

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md

-## Other
-
-This is a valid README.md file that follows the Beman Standard: the license is properly formatted - MIT License.
+This project is licensed under the Apache License 2.0 with LLVM Exceptions.


@JeffGarland , here is a valid and required update for this PR.

CC: @pysojic , please keep this change.

neatudarius · 2025-12-26T22:06:37Z

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md

 This is a valid README.md file that follows the Beman Standard: the library status is properly formatted.

-This is a valid README.md file that follows the Beman Standard: the license is properly formatted - MIT License.
+This is a valid README.md file that follows the Beman Standard: the license is properly formatted.


Suggested change

This is a valid README.md file that follows the Beman Standard: the license is properly formatted.

This is a valid README.md file that follows the Beman Standard: the license is properly formatted - Apache License.

Please be consistent with previous wording

neatudarius · 2025-12-26T22:11:06Z

tests/lib/checks/beman_standard/readme/test_readme.py

        Path(f"{valid_prefix}/README-v1.md"),
        Path(f"{valid_prefix}/README-v2.md"),
        Path(f"{valid_prefix}/README-v3.md"),
-        Path(f"{valid_prefix}/README-v4.md"),


We should not delete this. Check the comment for updating README-v4 to be still relevant readme.

neatudarius · 2025-12-26T22:11:12Z

tests/lib/checks/beman_standard/readme/test_readme.py

        Path(f"{valid_prefix}/README-v1.md"),
        Path(f"{valid_prefix}/README-v2.md"),
        Path(f"{valid_prefix}/README-v3.md"),
-        Path(f"{valid_prefix}/README-v4.md"),


We should not delete this. Check the comment for updating README-v4 to be still relevant readme.

neatudarius · 2025-12-26T22:11:21Z

tests/lib/checks/beman_standard/readme/test_readme.py

+        # License: Apache License 2.0 with LLVM Exceptions
        Path(f"{valid_prefix}/README-v3.md"),
-        # License: Apache License 2.0 with LLVM Exceptions and MIT License
-        Path(f"{valid_prefix}/README-v4.md"),


We should not delete this. Check the comment for updating README-v4 to be still relevant readme.

neatudarius · 2025-12-26T22:12:56Z

tests/lib/checks/beman_standard/readme/data/valid/README-v5.md

I don't see a reason to delete this file!

Again, it's used to increase coverage for multiple rules

license

badges

status lines

implement lines

The removal of files v4 and v5 are out of scope for current issue (MIT license). Please put v5 back

neatudarius · 2025-12-26T22:13:56Z

tests/lib/checks/beman_standard/readme/test_readme.py

        Path(f"{valid_prefix}/README-v2.md"),
        Path(f"{valid_prefix}/README-v3.md"),
-        Path(f"{valid_prefix}/README-v4.md"),
-        Path(f"{valid_prefix}/README-v5.md"),


Similarly, we should revert this line (keep v5 in tests).

Sounds good! Will make the changes you mentioned over the weekend!

JeffGarland · 2025-12-26T22:18:24Z

TLDR: You can ignore this PR for the moment. CC: @ednolan @JeffGarland

Approving -- we'll let you handle it :) Thx for the context

pysojic requested review from JeffGarland, ednolan, neatudarius, rishyak and vickgoodman as code owners December 25, 2025 03:43

Removed MIT as a supported license

8290df6

pysojic force-pushed the pierre branch from 08bbe6e to 8290df6 Compare December 25, 2025 04:07

neatudarius self-assigned this Dec 25, 2025

JeffGarland reviewed Dec 25, 2025

View reviewed changes

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md Show resolved Hide resolved

JeffGarland reviewed Dec 25, 2025

View reviewed changes

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md Show resolved Hide resolved

JeffGarland reviewed Dec 25, 2025

View reviewed changes

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md Show resolved Hide resolved

ednolan approved these changes Dec 26, 2025

View reviewed changes

neatudarius requested changes Dec 26, 2025

View reviewed changes

JeffGarland approved these changes Dec 26, 2025

View reviewed changes

	This is a valid README.md file that follows the Beman Standard: the license is properly formatted.
	This is a valid README.md file that follows the Beman Standard: the license is properly formatted - Apache License.

Removed MIT as a supported license #212

Are you sure you want to change the base?

Removed MIT as a supported license #212

Uh oh!

Conversation

pysojic commented Dec 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JeffGarland commented Dec 25, 2025

Uh oh!

ednolan commented Dec 26, 2025

Uh oh!

neatudarius commented Dec 26, 2025

Uh oh!

neatudarius commented Dec 26, 2025

Uh oh!

neatudarius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeffGarland commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants