Skip to content

Conversation

@ednolan
Copy link
Member

@ednolan ednolan commented Jul 13, 2025

This commit applies the following changes:

  • Add bemanproject/infra-workflows as a beman-submodule in .github/workflows
  • Add bemanproject/infra as a beman-submodule in infra/
  • Copy over the latest CMakePresets.json file from exemplar, except set the default to C++23 instead of C++20
  • Add an empty lockfile.json to make infra/cmake/use-fetch-content.cmake happy
  • Update the ci_tests.yml file to provide CI configurations for GCC 14-15 and Clang 19-20
  • Update the README to add a code coverage badge

This commit applies the following changes:

- Add bemanproject/infra-workflows as a beman-submodule in .github/workflows
- Add bemanproject/infra as a beman-submodule in infra/
- Copy over the latest CMakePresets.json file from exemplar, except set the default to C++23 instead of C++20
- Add an empty lockfile.json to make infra/cmake/use-fetch-content.cmake happy
- Update the ci_tests.yml file to provide CI configurations for GCC 14-15 and Clang 19-20
- Update the README to add a code coverage badge
@@ -0,0 +1 @@
* @ednolan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow -- this is a second codeowners file -- didn't know you could do that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this codeowners file has no effect here-- I was thinking about seeing if we can remove it because of how confusing it is. It shows up here because it's this codeowners file:

https://github.com/bemanproject/infra-workflows/blob/f1afd008de5fcee15a2a20a8b513e5dcde41e67e/.github/CODEOWNERS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

# MAC OS
*.DS_Store

# Editor files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need emacs on the standard set here -- thought I'd put that in exemplar, but this list is much longer than most repos...


include(FetchContent)

if(NOT BEMAN_EXEMPLAR_LOCKFILE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need to be renamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't need to be, but they should be-- these names are bad, but don't cause any conflicts or functional problems

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably open an issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ednolan ednolan merged commit 75f4e5c into bemanproject:main Jul 13, 2025
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants