-
Notifications
You must be signed in to change notification settings - Fork 2
Apply exemplar's new CI system #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit applies the following changes: - Add bemanproject/infra-workflows as a beman-submodule in .github/workflows - Add bemanproject/infra as a beman-submodule in infra/ - Copy over the latest CMakePresets.json file from exemplar, except set the default to C++23 instead of C++20 - Add an empty lockfile.json to make infra/cmake/use-fetch-content.cmake happy - Update the ci_tests.yml file to provide CI configurations for GCC 14-15 and Clang 19-20 - Update the README to add a code coverage badge
| @@ -0,0 +1 @@ | |||
| * @ednolan | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow -- this is a second codeowners file -- didn't know you could do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this codeowners file has no effect here-- I was thinking about seeing if we can remove it because of how confusing it is. It shows up here because it's this codeowners file:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
| # MAC OS | ||
| *.DS_Store | ||
|
|
||
| # Editor files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need emacs on the standard set here -- thought I'd put that in exemplar, but this list is much longer than most repos...
|
|
||
| include(FetchContent) | ||
|
|
||
| if(NOT BEMAN_EXEMPLAR_LOCKFILE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these need to be renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't need to be, but they should be-- these names are bad, but don't cause any conflicts or functional problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably open an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit applies the following changes: