Update the README.md and Makefile #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
requested review from
camio,
dietmarkuehl and
neatudarius
as code owners
Collaborator
Author
|
@dietmarkuehl I would like ask for a review |
dietmarkuehl
approved these changes
Jul 11, 2025
Member
dietmarkuehl
left a comment
dietmarkuehl
left a comment
There was a problem hiding this comment.
I can make the minor change to the README separately.
|
|
||
|
|
||
| cmake --workflow --preset release | ||
| CXX=g++-15 cmake --workflow --preset release |
Member
There was a problem hiding this comment.
I don't think the README should use a super recent compiler in its general build instructions. If there is a section on how to override compilers, e.g., to use a recent compiler, it could be used as an example (although I would prefer to keep the README fairly empty and have enhanced instructions elsewhere).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #169
and fix again a merge problem after #170