Make bulk pipeable #173
Merged
Make bulk pipeable #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andres-Salamanca
requested review from
camio,
dietmarkuehl and
neatudarius
as code owners
Member
Author
| namespace { | ||
| auto test_bulk() { | ||
| auto b0 = test_std::bulk(test_std::just(), 1, [](int) {}); | ||
| auto b0 = test_std::just() | test_std::bulk(1, [](int) {}); |
Member
There was a problem hiding this comment.
It seems odd to replace existing tests to cover new functionality. I’m aware that the new notation effectively calls into the original formulation and, this, implicitly tests what was previously tested. I tend to build test such that
the fundation is first tested separately.
Would it be viable to create new tests instead of modifying existing ones?
Member
Author
There was a problem hiding this comment.
Done, I reused the existing tests, but now implemented them using the pipe operator.
dietmarkuehl
approved these changes
Jul 29, 2025
Member
dietmarkuehl
left a comment
dietmarkuehl
left a comment
There was a problem hiding this comment.
Looks good! Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
bulkpipeable using the|operator by usingsender_adaptor_closureandsender_adaptorutilities. This allows bulk to be composed in pipelines.